[MERGED] osmo-bsc[master]: mgcp: add missing switch case

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: mgcp: add missing switch case
......................................................................


mgcp: add missing switch case

In the beginning of the CRCX phase for the network does not distinguish
between EV_MDCX_BTS_RES and EV_TEARDOWN, so a Teardown due to an error
could be misinterpreted as a successful MGW response.

Add missing case statement to distinguish CV_MDCX_BTS_RES from
EV_TEARDOWN.

Change-Id: I9bf49df167d94b33ad65d8b9382a01f160b5aec0
---
M src/osmo-bsc/osmo_bsc_mgcp.c
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_mgcp.c b/src/osmo-bsc/osmo_bsc_mgcp.c
index a7d1f94..be6c7de 100644
--- a/src/osmo-bsc/osmo_bsc_mgcp.c
+++ b/src/osmo-bsc/osmo_bsc_mgcp.c
@@ -456,6 +456,14 @@
 		 "fsm-state: %s, fsm-event: %s\n",
 		 get_value_string(fsm_bsc_mgcp_state_names, fi->state), get_value_string(fsm_evt_names, event));
 
+	switch (event) {
+	case EV_MDCX_BTS_RESP:
+		break;
+	default:
+		handle_error(mgcp_ctx, MGCP_ERR_UNEXP_TEARDOWN);
+		return;
+	}
+
 	rtp_endpoint = mgcp_ctx->rtp_endpoint;
 
 	LOGPFSML(mgcp_ctx->fsm, LOGL_DEBUG,

-- 
To view, visit https://gerrit.osmocom.org/4983
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9bf49df167d94b33ad65d8b9382a01f160b5aec0
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder