osmocom-bb[master]: mobile: Move starting/stopping a MS into a separate function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Dec 1 11:46:32 UTC 2017


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/5100/2/src/host/layer23/src/mobile/app_mobile.c
File src/host/layer23/src/mobile/app_mobile.c:

Line 262: 				"use the same layer2-socket.\nPlease shutdown "
> sure about \n in the middle of a LOGP? Makes sense in VTY output but "corru
the old code used VTY_NEWLINE instead of \n, which isn't any better either.  I think OsmocomBB needs a thorough clean up of such invalid use of libosmocore logging, but that shouldn't be mixed with this completely unrelated patch which just moves code around in this case.


-- 
To view, visit https://gerrit.osmocom.org/5100
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4aa5ff212fa6bead8f620abaecc6a0b51a99fec
Gerrit-PatchSet: 2
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Owner: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list