[MERGED] osmo-msc[master]: gsup client: move not-connected to error loglevel

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: gsup client: move not-connected to error loglevel
......................................................................


gsup client: move not-connected to error loglevel

Change-Id: I8290963aedb7237da89c9ff98adf4cd33beb5031
---
M src/libcommon/gsup_client.c
1 file changed, 2 insertions(+), 10 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/libcommon/gsup_client.c b/src/libcommon/gsup_client.c
index 258f230..fd65e7b 100644
--- a/src/libcommon/gsup_client.c
+++ b/src/libcommon/gsup_client.c
@@ -330,18 +330,10 @@
 
 int gsup_client_send(struct gsup_client *gsupc, struct msgb *msg)
 {
-	if (!gsupc) {
-		LOGP(DGPRS, LOGL_NOTICE, "No GSUP client, unable to "
-			"send %s\n", msgb_hexdump(msg));
+	if (!gsupc || !gsupc->is_connected) {
+		LOGP(DGPRS, LOGL_ERROR, "GSUP not connected, unable to send %s\n", msgb_hexdump(msg));
 		msgb_free(msg);
 		return -ENOTCONN;
-	}
-
-	if (!gsupc->is_connected) {
-		LOGP(DGPRS, LOGL_NOTICE, "GSUP not connected, unable to "
-			"send %s\n", msgb_hexdump(msg));
-		msgb_free(msg);
-		return -EAGAIN;
 	}
 
 	client_send(gsupc, IPAC_PROTO_EXT_GSUP, msg);

-- 
To view, visit https://gerrit.osmocom.org/3493
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8290963aedb7237da89c9ff98adf4cd33beb5031
Gerrit-PatchSet: 9
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder