[MERGED] libosmocore[master]: osmo-auc-gen: umts: remove erratic SQN.MS printout

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmo-auc-gen: umts: remove erratic SQN.MS printout
......................................................................


osmo-auc-gen: umts: remove erratic SQN.MS printout

osmo-auc-gen tries to be helpful by deriving the SQN.MS from the SQN that
resulted from AUTS + milenage_gen_vec(), but there is actually no way to derive
the actual AUTS SQN.MS from the resulting SQN.

Completely drop the printout to prevent confusion.

Adjust test suite expectations.

Related: OS#2464
Change-Id: Ie2432c6d6a23818f7b3a29b1295dcbb505e2be53
---
M tests/osmo-auc-gen/osmo-auc-gen_test.ok
M utils/osmo-auc-gen.c
2 files changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/tests/osmo-auc-gen/osmo-auc-gen_test.ok b/tests/osmo-auc-gen/osmo-auc-gen_test.ok
index fb7998f..6a78886 100644
--- a/tests/osmo-auc-gen/osmo-auc-gen_test.ok
+++ b/tests/osmo-auc-gen/osmo-auc-gen_test.ok
@@ -96,4 +96,3 @@
 SRES:	9b36efdf
 Kc:	059a4f668f6fbe39
 SQN:	24
-AUTS success: SQN.MS = 23
diff --git a/utils/osmo-auc-gen.c b/utils/osmo-auc-gen.c
index 76c4927..fade6ec 100644
--- a/utils/osmo-auc-gen.c
+++ b/utils/osmo-auc-gen.c
@@ -266,11 +266,5 @@
 			printf("SQN:\t%" PRIu64 "\n", test_aud.u.umts.sqn);
 	}
 
-	/* After recovering SQN.MS from AUTS, milenage_gen_vec_auts() does
-	 * aud->u.umts.sqn++, so to show SQN.MS we need to -1 */
-	if (auts_is_set)
-		printf("AUTS success: SQN.MS = %" PRIu64 "\n",
-		       test_aud.u.umts.sqn - 1);
-
 	exit(0);
 }

-- 
To view, visit https://gerrit.osmocom.org/3697
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2432c6d6a23818f7b3a29b1295dcbb505e2be53
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder