This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 5: Code-Review-1 I still don't like this patch - or don't understand it. If there is a bug, then we fix it instead of introducing a hack and a FIXME. I also don't see why there seems to be an assumption that any LCHAN_REL_ACT_REACT is related to SI3 / number of AGCH. The fact that SI3 related code is the only user of LCHAN_REL_ACT_REACT so far doesn't mean that one can make that assumption. Also, our aim should be to make all BTS models as similar as possible, rather than creating short-cuts for some of them. So my preference would clearly be to do a deactivation + re-actiovation as on other BTS models. Nobody will remember the subtle differences so let's avoid introducing any new ones without a really strong argument. -- To view, visit https://gerrit.osmocom.org/3067 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I20b89ba1e43d1414180b083cd1e085eeffe5d513 Gerrit-PatchSet: 5 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Ivan Kluchnikov <kluchnikovi at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: No