[MERGED] osmo-msc[master]: libmsc: Fix VTY output for handover counters.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Sun Aug 27 00:35:02 UTC 2017


Neels Hofmeyr has submitted this change and it was merged.

Change subject: libmsc: Fix VTY output for handover counters.
......................................................................


libmsc: Fix VTY output for handover counters.

Handover countrs belong to BSC, but we mistakenly take values from MSC counters.

Change-Id: I9512330f2e91d2f526751c5228e6e8e0fe17d579
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/libmsc/vty_interface_layer3.c b/src/libmsc/vty_interface_layer3.c
index d1bf6b3..1761ebc 100644
--- a/src/libmsc/vty_interface_layer3.c
+++ b/src/libmsc/vty_interface_layer3.c
@@ -570,11 +570,11 @@
 		VTY_NEWLINE);
 	vty_out(vty, "Handover                : %lu attempted, %lu no_channel, %lu timeout, "
 		"%lu completed, %lu failed%s",
-		net->msc_ctrs->ctr[BSC_CTR_HANDOVER_ATTEMPTED].current,
-		net->msc_ctrs->ctr[BSC_CTR_HANDOVER_NO_CHANNEL].current,
-		net->msc_ctrs->ctr[BSC_CTR_HANDOVER_TIMEOUT].current,
-		net->msc_ctrs->ctr[BSC_CTR_HANDOVER_COMPLETED].current,
-		net->msc_ctrs->ctr[BSC_CTR_HANDOVER_FAILED].current,
+		net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_ATTEMPTED].current,
+		net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_NO_CHANNEL].current,
+		net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_TIMEOUT].current,
+		net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_COMPLETED].current,
+		net->bsc_ctrs->ctr[BSC_CTR_HANDOVER_FAILED].current,
 		VTY_NEWLINE);
 	vty_out(vty, "SMS MO                  : %lu submitted, %lu no receiver%s",
 		net->msc_ctrs->ctr[MSC_CTR_SMS_SUBMITTED].current,

-- 
To view, visit https://gerrit.osmocom.org/3614
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9512330f2e91d2f526751c5228e6e8e0fe17d579
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list