[MERGED] osmo-msc[master]: remove code disabling T3109 if configured to 0

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: remove code disabling T3109 if configured to 0
......................................................................


remove code disabling T3109 if configured to 0

We no longer permit timers with a 0 value, so this case can never
happen.  Also, if it should happen, I'd rather have a timter expiring
immediately (and breaking something) than not being started in the
first place.

Change-Id: Ibfcdd3ddc0155caee89c501498329bde247621a0
---
M src/libbsc/abis_rsl.c
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/libbsc/abis_rsl.c b/src/libbsc/abis_rsl.c
index 9e36f79..3337b90 100644
--- a/src/libbsc/abis_rsl.c
+++ b/src/libbsc/abis_rsl.c
@@ -2910,10 +2910,6 @@
 {
 	struct gsm_bts *bts = lchan->ts->trx->bts;
 
-	/* Disabled, mostly legacy code */
-	if (bts->network->T3109 == 0)
-		return -1;
-
 	osmo_timer_setup(&lchan->T3109, t3109_expired, lchan);
 	osmo_timer_schedule(&lchan->T3109, bts->network->T3109, 0);
 	return 0;

-- 
To view, visit https://gerrit.osmocom.org/3629
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfcdd3ddc0155caee89c501498329bde247621a0
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>