[MERGED] osmo-msc[master]: utils: smpp_mirror: reflect message reference TLV

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: utils: smpp_mirror: reflect message reference TLV
......................................................................


utils: smpp_mirror: reflect message reference TLV

Useful to test the delivery receipt support. This TLV contains the
GSM03.40 message reference.

Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f
---
M src/utils/smpp_mirror.c
1 file changed, 23 insertions(+), 1 deletion(-)

Approvals:
  Neels Hofmeyr: Looks good to me, approved



diff --git a/src/utils/smpp_mirror.c b/src/utils/smpp_mirror.c
index edb40b5..88545de 100644
--- a/src/utils/smpp_mirror.c
+++ b/src/utils/smpp_mirror.c
@@ -95,12 +95,23 @@
 }
 /* FIXME: merge with smpp_smsc.c */
 
+static struct tlv_t *find_tlv(struct tlv_t *head, uint16_t tag)
+{
+	struct tlv_t *t;
+
+	for (t = head; t != NULL; t = t->next) {
+		if (t->tag == tag)
+			return t;
+	}
+	return NULL;
+}
 
 static int smpp_handle_deliver(struct esme *esme, struct msgb *msg)
 {
 	struct deliver_sm_t deliver;
 	struct deliver_sm_resp_t deliver_r;
 	struct submit_sm_t submit;
+	tlv_t *t;
 	int rc;
 
 	memset(&deliver, 0, sizeof(deliver));
@@ -155,7 +166,18 @@
 	memcpy(submit.short_message, deliver.short_message,
 		OSMO_MIN(sizeof(submit.short_message),
 			 sizeof(deliver.short_message)));
-	/* FIXME: TLV? */
+
+	/* FIXME: More TLV? */
+	t = find_tlv(deliver.tlv, TLVID_user_message_reference);
+	if (t) {
+		tlv_t tlv;
+
+		memset(&tlv, 0, sizeof(tlv));
+		tlv.tag = TLVID_user_message_reference;
+		tlv.length = 2;
+		tlv.value.val16 = t->value.val16;
+		build_tlv(&submit.tlv, &tlv);
+	}
 
 	return PACK_AND_SEND(esme, &submit);
 }

-- 
To view, visit https://gerrit.osmocom.org/3645
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>