[MERGED] osmo-bts[master]: osmo-bts-trx: fix 'osmotrx legacy-setbsic'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Aug 24 19:06:49 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: osmo-bts-trx: fix 'osmotrx legacy-setbsic'
......................................................................


osmo-bts-trx: fix 'osmotrx legacy-setbsic'

It was introduced in fe6c75d24a1751341bcee91cb45c7ac7f5d07da3:

* fix typo in config write
* add missing vty help string

Change-Id: Id42359dfbb8ad02f34dd2540db66f3ed69ad5181
---
M src/osmo-bts-trx/trx_vty.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index 482248c..36d75c1 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -458,7 +458,7 @@
 }
 
 DEFUN(cfg_phy_setbsic, cfg_phy_setbsic_cmd,
-	"osmotrx legacy-setbsic",
+	"osmotrx legacy-setbsic", OSMOTRX_STR
 	"Use SETBSIC to configure transceiver (use ONLY with OpenBTS Transceiver!)\n")
 {
 	struct phy_link *plink = vty->index;
@@ -473,7 +473,7 @@
 
 DEFUN(cfg_phy_no_setbsic, cfg_phy_no_setbsic_cmd,
 	"no osmotrx legacy-setbsic",
-	NO_STR "Disable Legacy SETBSIC to configure transceiver\n")
+	NO_STR OSMOTRX_STR "Disable Legacy SETBSIC to configure transceiver\n")
 {
 	struct phy_link *plink = vty->index;
 	plink->u.osmotrx.use_legacy_setbsic = false;
@@ -503,7 +503,7 @@
 		plink->u.osmotrx.rts_advance, VTY_NEWLINE);
 
 	if (plink->u.osmotrx.use_legacy_setbsic)
-		vty_out(vty, " osmotrx leyacy-setbsic%s", VTY_NEWLINE);
+		vty_out(vty, " osmotrx legacy-setbsic%s", VTY_NEWLINE);
 }
 
 void bts_model_config_write_phy_inst(struct vty *vty, struct phy_instance *pinst)

-- 
To view, visit https://gerrit.osmocom.org/3602
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id42359dfbb8ad02f34dd2540db66f3ed69ad5181
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list