openbsc[master]: SGSN: log IMSI on PDP context creation/deletion

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Aug 24 19:02:26 UTC 2017


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/3575/3/openbsc/src/gprs/sgsn_libgtp.c
File openbsc/src/gprs/sgsn_libgtp.c:

Line 148: 	LOGP(DGPRS, LOGL_ERROR, "Create PDP Context for %s\n", mmctx->imsi);
I think if you want to do this, it would make sense to also print the NSAPI, as only the tuple of IMSI:NSAPI uniquely identifies a PDP context.  Same for the deletion callback below.  I've introduced recent changes in OpenGGSN by having some logging wrapper macros like LOGPPDP() or the like.  Could make sense here, too


-- 
To view, visit https://gerrit.osmocom.org/3575
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ada9f85af2098f9acc8a277b9026eed226b9ac2
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list