This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/3656 mgcp_osmux: Remove unused parameter Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3 --- M include/openbsc/osmux.h M src/libmgcp/mgcp_osmux.c 2 files changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/56/3656/1 diff --git a/include/openbsc/osmux.h b/include/openbsc/osmux.h index 0b64a7f..f3ea72a 100644 --- a/include/openbsc/osmux.h +++ b/include/openbsc/osmux.h @@ -11,8 +11,7 @@ }; int osmux_init(int role, struct mgcp_config *cfg); -int osmux_enable_endpoint(struct mgcp_endpoint *endp, int role, - struct in_addr *addr, uint16_t port); +int osmux_enable_endpoint(struct mgcp_endpoint *endp, struct in_addr *addr, uint16_t port); void osmux_disable_endpoint(struct mgcp_endpoint *endp); void osmux_allocate_cid(struct mgcp_endpoint *endp); void osmux_release_cid(struct mgcp_endpoint *endp); diff --git a/src/libmgcp/mgcp_osmux.c b/src/libmgcp/mgcp_osmux.c index b46a80e..c52984b 100644 --- a/src/libmgcp/mgcp_osmux.c +++ b/src/libmgcp/mgcp_osmux.c @@ -340,8 +340,7 @@ if (endp->osmux.state == OSMUX_STATE_ENABLED) goto out; - if (osmux_enable_endpoint(endp, OSMUX_ROLE_BSC_NAT, - &addr->sin_addr, addr->sin_port) < 0 ){ + if (osmux_enable_endpoint(endp, &addr->sin_addr, addr->sin_port) < 0 ) { LOGP(DMGCP, LOGL_ERROR, "Could not enable osmux in endpoint %d\n", ENDPOINT_NUMBER(endp)); @@ -433,8 +432,7 @@ return 0; } -int osmux_enable_endpoint(struct mgcp_endpoint *endp, int role, - struct in_addr *addr, uint16_t port) +int osmux_enable_endpoint(struct mgcp_endpoint *endp, struct in_addr *addr, uint16_t port) { /* If osmux is enabled, initialize the output handler. This handler is * used to reconstruct the RTP flow from osmux. The RTP SSRC is @@ -522,8 +520,7 @@ return 0; if (endp->osmux.state == OSMUX_STATE_ACTIVATING) { - if (osmux_enable_endpoint(endp, OSMUX_ROLE_BSC, - &endp->net_end.addr, + if (osmux_enable_endpoint(endp, &endp->net_end.addr, htons(endp->cfg->osmux_port)) < 0) { LOGP(DMGCP, LOGL_ERROR, "Could not activate osmux in endpoint %d\n", -- To view, visit https://gerrit.osmocom.org/3656 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3 Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>