libosmo-netif[master]: osmux: Re-write osmux_snprintf

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pablo Neira Ayuso gerrit-no-reply at lists.osmocom.org
Mon Aug 21 14:52:37 UTC 2017


Patch Set 1:

@Pau: You're not the only one getting confused with it, snprintf() is a mess, it's hard to deal with it, hence this macro that retains semantics that aims to simplify things... if you find any better, let me know I'd be happy to reuse it in my code moving forward :-).

@Holger: Either way, I don't mind if you don't need the snprintf semantics, this is a _snprintf() function after all, just explaning here. So the intention at least that I can remember was to keep in sync with how snprintf() works. Anyway, feel free to simplify this.

Anyway, I just wanted to make sure this patch was really fixing up the real issue. I understand you observe a crash, but not clear to me why the patch is fixing it.

Cheers.

-- 
To view, visit https://gerrit.osmocom.org/3537
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I695771d099833842db37a415b636035d17f1bba7
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list