libosmocore[master]: gsm0411_utils: GSM03.40 9.2.3.11 SCTS should be local

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Fri Aug 18 10:29:06 UTC 2017


Patch Set 1:

> This oneliner LGTM.
 > 
 > Is this fixing up the issue you were observing with Delivery
 > Reports with wrong dates?

wrong dates/times... Yes. 
The phones that actually show the date/time show it as it is placed into the SCTS field. The spec is clear that this should be local to SME. 

The spec mentions that the GMT offset /can/ be used by the phone if it is aware of it's own timezone. As far as I can make out, with gmtime() the offset is ALWAYS going to be 0.

There is another issue, as far as I can see, if the offset is negative, this is never going to be encoded correctly by gsm411_bcdify() 

Note that I am very much doing virgoan nitpicking here, nowadays the number of phones that actual display this time is minimal, it seems most of them use their own clock to timestamp messages. :)

-- 
To view, visit https://gerrit.osmocom.org/3551
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4efdb1eaae43aced33961b64d4f14b0040321c10
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-HasComments: No



More information about the gerrit-log mailing list