[MERGED] osmo-gsm-tester[master]: esme: user_message_referece values should be smaller than 256

[Pau Espin Pedrol]

Pau Espin Pedrol has submitted this change and it was merged.

Change subject: esme: user_message_referece values should be smaller than 256
......................................................................


esme: user_message_referece values should be smaller than 256

SMPP specs say message reference is 16 bits field.
However, message reference field in GSM03.40 spec is only 8 bits.

Change-Id: I52968a10089d14e0e3b0f9be678c261e3f92939c
---
M src/osmo_gsm_tester/esme.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Pau Espin Pedrol: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_gsm_tester/esme.py b/src/osmo_gsm_tester/esme.py
index c838841..9dbc5a3 100644
--- a/src/osmo_gsm_tester/esme.py
+++ b/src/osmo_gsm_tester/esme.py
@@ -145,7 +145,7 @@
         seqs = []
         self.log('Sending SMS "%s" to %s' % (str(sms_obj), sms_obj.dst_msisdn()))
         umref = self.next_user_message_reference
-        self.next_user_message_reference += 1
+        self.next_user_message_reference = (self.next_user_message_reference + 1) % (1 << 8)
         for part in parts:
             pdu = self.client.send_message(
                 source_addr_ton=smpplib.consts.SMPP_TON_INTL,

-- 
To view, visit https://gerrit.osmocom.org/3549
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52968a10089d14e0e3b0f9be678c261e3f92939c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Pau Espin Pedrol <pespin at sysmocom.de>