openbsc[master]: SMS Delivery reports: Use actual delivery time, not time of ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Keith Whyte gerrit-no-reply at lists.osmocom.org
Thu Aug 17 15:43:45 UTC 2017


Patch Set 1:

> (1 comment)

After reading the spec again, getting localtime from sqlite is wrong anyway. It should be as it is: Use UTC and specific the timezone offset in libosmocore in gsm340_gen_scts().

Only I'm getting tm->tm_gmtoff = 0 and tm->tm_zone = GMT. from gmtime() there, even though the box running the nitb is all setup for CEST.
I set TZ before running osmo-nitb.

What's more, If I manually over ride tm->tm_gmtoff in gsm340_gen_scts():
    -*scts++ = gsm411_bcdify(tm->tm_gmtoff/(60*15));
    +*scts++ = gsm411_bcdify(8);
the phone still shows the message received two hours before it was sent :-/

-- 
To view, visit https://gerrit.osmocom.org/3540
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9056429d40bf02731f004b7833f1de45a0d1add8
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <keith at rhizomatica.org>
Gerrit-Reviewer: Pablo Neira Ayuso <pablo at gnumonks.org>
Gerrit-HasComments: No



More information about the gerrit-log mailing list