[PATCH] osmo-gsm-tester[master]: esme: smpp pdu field is a string and needs conversion

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Pau Espin Pedrol gerrit-no-reply at lists.osmocom.org
Thu Aug 17 15:07:59 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/3548

to look at the new patch set (#2).

esme: smpp pdu field is a string and needs conversion

I take the chance to also swap the two log parameters, because they are
included into a dictionary and shown in swapped order in the log anyway,
which distracts me every time I look at the values.

Change-Id: I6e6ec5b9980958de82ade40e4cd898dc6f1b889f
---
M src/osmo_gsm_tester/esme.py
1 file changed, 3 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/48/3548/2

diff --git a/src/osmo_gsm_tester/esme.py b/src/osmo_gsm_tester/esme.py
index 376152a..c838841 100644
--- a/src/osmo_gsm_tester/esme.py
+++ b/src/osmo_gsm_tester/esme.py
@@ -121,8 +121,9 @@
         if isinstance(pdu, smpplib.command.AlertNotification):
             self.dbg('message received:  AlertNotification:', ms_availability_status=pdu.ms_availability_status)
         elif isinstance(pdu, smpplib.command.DeliverSM):
-            self.dbg('message received:', user_message_reference=pdu.user_message_reference, references_pending_receipt=self.references_pending_receipt)
-            self.references_pending_receipt.remove(pdu.user_message_reference)
+            umref = int(pdu.user_message_reference)
+            self.dbg('message received: DeliverSM', references_pending_receipt=self.references_pending_receipt, user_message_reference=umref)
+            self.references_pending_receipt.remove(umref)
 
     def receipt_was_received(self, umref):
         # return umref not in self.references_pending_receipt

-- 
To view, visit https://gerrit.osmocom.org/3548
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e6ec5b9980958de82ade40e4cd898dc6f1b889f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list