This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: sccp: fix handling of default IP addresses in osmo_sccp_simple_client() ...................................................................... sccp: fix handling of default IP addresses in osmo_sccp_simple_client() When the default IP addresses (remote or local) the respective struct value should be set to NULL. Fix wrong ?:-notation. Change-Id: I312caf9d54cedb02034e4ef88fdd2e6ad9ca1c34 --- M src/sccp_user.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sccp_user.c b/src/sccp_user.c index 9116b60..4e28aa0 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -404,10 +404,10 @@ goto out_rt; asp_created = true; - default_local_ip ? asp->cfg.local.host = - talloc_strdup(asp, default_local_ip) : NULL; - default_remote_ip ? asp->cfg.remote.host = - talloc_strdup(asp, default_remote_ip) : NULL; + asp->cfg.local.host = + default_local_ip ? asp->cfg.local.host : NULL; + asp->cfg.remote.host = + default_remote_ip ? asp->cfg.remote.host : NULL; osmo_ss7_as_add_asp(as, asp->cfg.name); } -- To view, visit https://gerrit.osmocom.org/3479 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I312caf9d54cedb02034e4ef88fdd2e6ad9ca1c34 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder