libosmocore[master]: gsm0480: modify USSD structures to support external handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Wed Aug 9 10:16:10 UTC 2017


Patch Set 2:

The problem is that you're breaking API + ABI.  The symbol stll exists, and code compiled against the old version of the symbol will crash in a non-obvious way.

So I would prefer any solution that avoids this.  Simply renaming the function would solve it, as then an old program would simply no longer start against the new library due to the missing symbol. 

bumping the libversion is something we only do as part of the tag/release process, and thus doesn't help immedaitely.  We either need to change that policy, or we need a different solution that involes having the new function under a new name (whether or not the old function continues).

-- 
To view, visit https://gerrit.osmocom.org/3374
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f8972b86cd4dcb54b643a24b5794a87c8758073
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Alexander Chemeris <Alexander.Chemeris at gmail.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Ivan Kluchnikov <kluchnikovi at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No



More information about the gerrit-log mailing list