[PATCH] openggsn[master]: Proper fix for "Force Dynamic IP" in Create PDP CTX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Aug 3 22:24:25 UTC 2017


Review at  https://gerrit.osmocom.org/3409

Proper fix for "Force Dynamic IP" in Create PDP CTX

An EUA length of *2* octets indicates dynamic IP address, while
an EUA length of 0 is invalid.  Let's fix this hack (which needs
to finally be removed anyway).

Change-Id: Ib1b57eb0654327882044d6862d955f4b32aa6bcd
---
M ggsn/ggsn.c
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/openggsn refs/changes/09/3409/1

diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c
index 4d07f11..168e907 100644
--- a/ggsn/ggsn.c
+++ b/ggsn/ggsn.c
@@ -173,7 +173,9 @@
 
 	DEBUGP(DGGSN, "Received create PDP context request\n");
 
-	pdp->eua.l = 0;		/* TODO: Indicates dynamic IP */
+	/* FIXME: we manually force all context requests to dynamic here! */
+	if (pdp->eua.l > 2)
+		pdp->eua.l = 2;
 
 	memcpy(pdp->qos_neg0, pdp->qos_req0, sizeof(pdp->qos_req0));
 	memcpy(&pdp->pco_neg, &pco, sizeof(pdp->pco_neg));

-- 
To view, visit https://gerrit.osmocom.org/3409
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1b57eb0654327882044d6862d955f4b32aa6bcd
Gerrit-PatchSet: 1
Gerrit-Project: openggsn
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list