[MERGED] libosmo-sccp[master]: m3ua_to_xfer_ind(): don't use data_ie without checking it ex...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: m3ua_to_xfer_ind(): don't use data_ie without checking it exists
......................................................................


m3ua_to_xfer_ind(): don't use data_ie without checking it exists

Change-Id: I5f7551e49c1b4ea417bee3516da1b2ece5ee0699
Fixes: coverity CID#166941
---
M src/osmo_ss7_hmrt.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo_ss7_hmrt.c b/src/osmo_ss7_hmrt.c
index 393530a..e66762d 100644
--- a/src/osmo_ss7_hmrt.c
+++ b/src/osmo_ss7_hmrt.c
@@ -25,7 +25,7 @@
 	struct m3ua_data_hdr *data_hdr;
 	struct msgb *upmsg = m3ua_msgb_alloc("M3UA MTP-TRANSFER.ind");
 
-	if (data_ie->len < sizeof(*data_hdr)) {
+	if (!data_ie || data_ie->len < sizeof(*data_hdr)) {
 		/* FIXME: ERROR message */
 		msgb_free(upmsg);
 		return NULL;

-- 
To view, visit https://gerrit.osmocom.org/2435
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5f7551e49c1b4ea417bee3516da1b2ece5ee0699
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder