This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: sccp_scoc: don't pass variable as argument if we know it's NULL ...................................................................... sccp_scoc: don't pass variable as argument if we know it's NULL xua will always be NULL in one particular switch case of scoc_fsm_conn_pend_out(), so let's use NULL directly rather than obscure it though a variable that might be understood as this being non-NULL in some cases. Change-Id: Id6dc56442441489aefc706bcebc49197ca3dae1e Fixes: coverity CID#166934 --- M src/sccp_scoc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index 0eda7ad..5e91ea4 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -824,7 +824,7 @@ break; case SCOC_E_CONN_TMR_EXP: /* N-DISCONNECT.ind to user */ - scu_gen_encode_and_send(conn, event, xua, OSMO_SCU_PRIM_N_DISCONNECT, + scu_gen_encode_and_send(conn, event, NULL, OSMO_SCU_PRIM_N_DISCONNECT, PRIM_OP_INDICATION); /* below implicitly releases resources + local ref */ osmo_fsm_inst_state_chg(fi, S_IDLE, 0, 0); -- To view, visit https://gerrit.osmocom.org/2438 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6dc56442441489aefc706bcebc49197ca3dae1e Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder