This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: sccp_user: Add missing 'break' statement ...................................................................... sccp_user: Add missing 'break' statement The missing break statement leads to an unintended fall-through which in turn prints a wrong ERROR message. Change-Id: I6618fa247b889d4162118278cd05dee85cf21899 Fixes: coverity CID#166948 --- M src/sccp_user.c 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sccp_user.c b/src/sccp_user.c index d9e40b6..5f89f71 100644 --- a/src/sccp_user.c +++ b/src/sccp_user.c @@ -168,6 +168,7 @@ xua->mtp = omp->u.transfer; /* hand this primitive into SCCP via the SCRC code */ rc = scrc_rx_mtp_xfer_ind_xua(inst, xua); + break; default: LOGP(DLSCCP, LOGL_ERROR, "Unknown primitive %u:%u receivd\n", oph->primitive, oph->operation); -- To view, visit https://gerrit.osmocom.org/2429 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6618fa247b889d4162118278cd05dee85cf21899 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder