[MERGED] osmo-bts[master]: Fix RTP duration adjustment not done when speech resumes in ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Thu Apr 27 10:14:59 UTC 2017


Max has submitted this change and it was merged.

Change subject: Fix RTP duration adjustment not done when speech resumes in DTX mode.
......................................................................


Fix RTP duration adjustment not done when speech resumes in DTX mode.

RTP jitter increases continuously because duration is not
updated when speech resumes in DTX mode.

Change-Id: Ib51ed95a449369222c957b3acebd9ce1f66c5435
---
M src/common/l1sap.c
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index 57a858c..6c509e3 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -76,12 +76,8 @@
 {
 	uint32_t samples_passed, r;
 
-	/* don't adjust duration:
-	   - when no DTX enabled at all
-	   - for ONSET RTP packet to avoid timestamp gap with subsequent SPEECH
-	   RTP packet*/
-	if (lchan->rtp_tx_marker ||
-	    lchan->ts->trx->bts->dtxu == GSM48_DTX_SHALL_NOT_BE_USED)
+	/* don't adjust duration when DTX is not enabled */
+	if (lchan->ts->trx->bts->dtxu == GSM48_DTX_SHALL_NOT_BE_USED)
 		return GSM_RTP_DURATION;
 
 	if (lchan->tch.last_fn != LCHAN_FN_DUMMY) {

-- 
To view, visit https://gerrit.osmocom.org/1983
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib51ed95a449369222c957b3acebd9ce1f66c5435
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: jfdionne <jf.dionne at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list