[PATCH] libosmo-sccp[master]: m3ua_decode_notify(): Ensure status_ie is valid before using it

[Harald Welte]

Review at  https://gerrit.osmocom.org/2437

m3ua_decode_notify(): Ensure status_ie is valid before using it

Change-Id: I3cdd0fbdffcbeeb68dbc979385de045220ea0b0c
Fixes: coverity CID#166939
---
M src/m3ua.c
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/37/2437/1

diff --git a/src/m3ua.c b/src/m3ua.c
index b204708..d96bd18 100644
--- a/src/m3ua.c
+++ b/src/m3ua.c
@@ -412,6 +412,10 @@
 
 	/* cannot use xua_msg_get_u32() as it does endian conversion */
 	status_ie = xua_msg_find_tag(xua, M3UA_IEI_STATUS);
+	if (!status_ie) {
+		LOGP(DLM3UA, LOGL_ERROR, "M3UA NOTIFY without Status IE\n");
+		return -1;
+	}
 	status = *(uint32_t *) status_ie->dat;
 
 	aspid_ie = xua_msg_find_tag(xua, M3UA_IEI_ASP_ID);

-- 
To view, visit https://gerrit.osmocom.org/2437
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cdd0fbdffcbeeb68dbc979385de045220ea0b0c
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>