[PATCH] libosmo-sccp[master]: ss7_test: Avoid possible NULL pointer dereference in test case

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Apr 27 08:56:36 UTC 2017


Review at  https://gerrit.osmocom.org/2425

ss7_test: Avoid possible NULL pointer dereference in test case

Change-Id: If2a7b2c988d06e8bbd2a63f3a5ceeb403bfb34ed
Fixes: coverity CID#166992
---
M tests/ss7/ss7_test.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/25/2425/1

diff --git a/tests/ss7/ss7_test.c b/tests/ss7/ss7_test.c
index 24eabc9..e36e068 100644
--- a/tests/ss7/ss7_test.c
+++ b/tests/ss7/ss7_test.c
@@ -235,6 +235,7 @@
 
 	OSMO_ASSERT(osmo_ss7_as_find_by_name(s7i, "as1") == NULL);
 	as = osmo_ss7_as_find_or_create(s7i, "as1", OSMO_SS7_ASP_PROT_M3UA);
+	OSMO_ASSERT(as);
 	OSMO_ASSERT(osmo_ss7_as_find_by_name(s7i, "as1") == as);
 	OSMO_ASSERT(osmo_ss7_as_find_by_rctx(s7i, 2342) == NULL);
 	as->cfg.routing_key.context = 2342;

-- 
To view, visit https://gerrit.osmocom.org/2425
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2a7b2c988d06e8bbd2a63f3a5ceeb403bfb34ed
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list