[PATCH] osmo-bts[master]: WIP: measurement: fix measurement report interval lookup tables

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Apr 26 09:38:40 UTC 2017


Review at  https://gerrit.osmocom.org/2416

WIP: measurement: fix measurement report interval lookup tables

The measurment reporting interval, generated from the lookup
defind at the beginning of the source code file (*_meas_rep_fn104[])
is off by one, in some case off by 2. This commit corrects the
timing by subtracting 1 or 2 from the respective lookup table.

NOTE: This is still work in progress. To me this looks like something,
that might be octasic specific. Is this allignment really needed
for all BTS models?

Change-Id: I471a767c7974bdacadc3233d0c3e7b7965f6eafa
---
M src/common/measurement.c
1 file changed, 29 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/16/2416/1

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 5613894..e1adb8d 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -24,35 +24,40 @@
  * 7                         6 and 7        91 to 90     103, 25,  51,  77 */
 
 /* measurement period ends at fn % 104 == ? */
+/* Added (-1) offset in DATA-IND frame number to align with Meas period ends */
 static const uint8_t tchf_meas_rep_fn104[] = {
-	[0] =	103,
-	[1] =	12,
-	[2] =	25,
-	[3] =	38,
-	[4] =	51,
-	[5] =	64,
-	[6] =	77,
-	[7] =	90,
+	[0] =	103 - 1,
+	[1] =	12 - 1,
+	[2] =	25 - 1,
+	[3] =	38 - 1,
+	[4] =	51 - 1,
+	[5] =	64 - 1,
+	[6] =	77 - 1,
+	[7] =	90 - 1,
 };
+
+/* Added (-2) offset in DATA-IND frame number to align with Meas period ends */
 static const uint8_t tchh0_meas_rep_fn104[] = {
-	[0] =	103,
-	[1] =	103,
-	[2] =	25,
-	[3] =	25,
-	[4] =	51,
-	[5] =	51,
-	[6] =	77,
-	[7] =	77,
+	[0] =	103 - 2,
+	[1] =	103 - 2,
+	[2] =	25 - 2,
+	[3] =	25 - 2,
+	[4] =	51 - 2,
+	[5] =	51 - 2,
+	[6] =	77 - 2,
+	[7] =	77 - 2,
 };
+
+/* Added (-1) offset in DATA-IND frame number to align with Meas period ends */
 static const uint8_t tchh1_meas_rep_fn104[] = {
-	[0] =	12,
-	[1] =	12,
-	[2] =	38,
-	[3] =	38,
-	[4] =	64,
-	[5] =	64,
-	[6] =	90,
-	[7] =	90,
+	[0] =	12 - 1,
+	[1] =	12 - 1,
+	[2] =	38 - 1,
+	[3] =	38 - 1,
+	[4] =	64 - 1,
+	[5] =	64 - 1,
+	[6] =	90 - 1,
+	[7] =	90 - 1,
 };
 
 /* Measurment reporting period for SDCCH8 and SDCCH4 chan

-- 
To view, visit https://gerrit.osmocom.org/2416
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I471a767c7974bdacadc3233d0c3e7b7965f6eafa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list