[PATCH] osmo-bts[master]: measurement/cosmetic: Fixup source code comment

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu Apr 20 13:14:36 UTC 2017


Review at  https://gerrit.osmocom.org/2388

measurement/cosmetic: Fixup source code comment

the function is_meas_complete() uses the *_meas_rep_fn104[]
lookup tables, defined at the beginning of the source file.

These lookup tabels contain a lot of magic numbers. This
commit adds a more elaborated comment with a reference
to the specification/section in order make the values
understandable.

Change-Id: Ic6e4037f965772e6b851c67662d5e7bf64cc04eb
---
M src/common/measurement.c
1 file changed, 15 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/2388/1

diff --git a/src/common/measurement.c b/src/common/measurement.c
index 0814bf1..8076413 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -8,7 +8,21 @@
 #include <osmo-bts/logging.h>
 #include <osmo-bts/measurement.h>
 
-/* TS 05.08, Chapter 8.4.1 */
+/* Measurment reporting period and mapping of SACCH message block for TCHF
+ * and TCHH chan As per in 3GPP TS 45.008, secton 8.4.1.
+ *
+ *             Timeslot number (TN)        TDMA frame number (FN) modulo 104
+ *             Half rate,    Half rate,     Reporting    SACCH
+ * Full Rate   subch.0       subch.1        period       Message block
+ * 0           0 and 1                      0 to 103     12,  38,  64,  90
+ * 1                         0 and 1        13 to 12     25,  51,  77,  103
+ * 2           2 and 3                      26 to 25     38,  64,  90,  12
+ * 3                         2 and 3        39 to 38     51,  77,  103, 25
+ * 4           4 and 5                      52 to 51     64,  90,  12,  38
+ * 5                         4 and 5        65 to 64     77,  103, 25,  51
+ * 6           6 and 7                      78 to 77     90,  12,  38,  64
+ * 7                         6 and 7        91 to 90     103, 25,  51,  77 */
+
 /* measurement period ends at fn % 104 == ? */
 static const uint8_t tchf_meas_rep_fn104[] = {
 	[0] =	103,

-- 
To view, visit https://gerrit.osmocom.org/2388
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6e4037f965772e6b851c67662d5e7bf64cc04eb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list