openbsc[master]: Save PCU version reported by BTS

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Apr 18 13:03:55 UTC 2017


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/2289/1/openbsc/src/libbsc/abis_nm.c
File openbsc/src/libbsc/abis_nm.c:

Line 317: 			osmo_strlcpy(bts->pcu_version, text, MAX_VERSION_LENGTH);
when copying to some buffer, it always makes sense to use sizeof(buffer). If somebody changes bts->pcu_version[] to have a size differetn than MAX_VERSION_LENGTH, your code will break.  If you use sizeof(bts->pcu_version), it should continue to work.


-- 
To view, visit https://gerrit.osmocom.org/2289
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb32c73036413ee912f633604150ee17b611cfa7
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list