[MERGED] libosmo-sccp[master]: SUA: Reject unknown Connectionless Message Types

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: SUA: Reject unknown Connectionless Message Types
......................................................................


SUA: Reject unknown Connectionless Message Types

This was found by sua-sgp-mtr-i-03 of Michael Tuexen's sua-testtool.

Change-Id: I09e96a26d9f9398de07ab46cdc5af10b2ea5acc0
---
M src/sua.c
1 file changed, 11 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/sua.c b/src/sua.c
index 97a0785..f003f7b 100644
--- a/src/sua.c
+++ b/src/sua.c
@@ -498,6 +498,17 @@
 {
 	struct osmo_sccp_instance *inst = asp->inst->sccp;
 
+	OSMO_ASSERT(xua->hdr.msg_class == SUA_MSGC_CL);
+
+	switch (xua->hdr.msg_type) {
+	case 0: /* Reserved, permitted by ETSI TS 101 592 5.2.3.2 */
+	case SUA_CL_CLDT:
+	case SUA_CL_CLDR:
+		break;
+	default:
+		return SUA_ERR_UNSUPP_MSG_TYPE;
+	}
+
 	/* We feed into SCRC, which then hands the message into
 	 * either SCLC or SCOC, or forwards it to MTP */
 	return scrc_rx_mtp_xfer_ind_xua(inst, xua);

-- 
To view, visit https://gerrit.osmocom.org/2383
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I09e96a26d9f9398de07ab46cdc5af10b2ea5acc0
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder