This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: xua_asp_fsm: Fix ordering of messages to pass M3UA_SGP_ASPSM_O_003 ...................................................................... xua_asp_fsm: Fix ordering of messages to pass M3UA_SGP_ASPSM_O_003 I don't think the order of messages is that important (and specified in the RFC), but let's do this to make the m3ua-testtool case happy. Change-Id: I2e150e941a6fcfd203944f5b20bd07c07193f44a --- M src/xua_asp_fsm.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index ce15038..a0f93bd 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -546,10 +546,11 @@ * an Error message ("Unexpected Message), and the * remote ASP state is changed to ASP-INACTIVE in all * relevant Application Servers */ + peer_send_error(fi, M3UA_ERR_UNEXPECTED_MSG); osmo_fsm_inst_state_chg(fi, XUA_ASP_S_INACTIVE, 0, 0); + peer_send(fi, XUA_ASP_E_ASPSM_ASPUP_ACK, NULL); send_xlm_prim_simple(fi, OSMO_XLM_PRIM_M_ASP_INACTIVE, PRIM_OP_INDICATION); - peer_send_error(fi, M3UA_ERR_UNEXPECTED_MSG); break; case XUA_ASP_E_ASPTM_ASPAC: /* only in role SG */ -- To view, visit https://gerrit.osmocom.org/2382 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e150e941a6fcfd203944f5b20bd07c07193f44a Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Owner: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder