[MERGED] libosmo-netif[master]: stream.c: Fix SCTP_NODELAY setting

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Apr 16 22:22:52 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: stream.c: Fix SCTP_NODELAY setting
......................................................................


stream.c: Fix SCTP_NODELAY setting

We were using the wrong variable when setting the SCTP_NODELAY,
resulting in the setsoctkopt() fialing.

Change-Id: Ic04cb8bb5ff41f177f7f5b7f7e2a2ecc686dd4c0
---
M src/stream.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/stream.c b/src/stream.c
index 653f26b..ed73a62 100644
--- a/src/stream.c
+++ b/src/stream.c
@@ -551,7 +551,7 @@
 	}
 
 	if (link->flags & OSMO_STREAM_SRV_F_NODELAY) {
-		ret = setsockopt_nodelay(ret, link->proto, 1);
+		ret = setsockopt_nodelay(sock_fd, link->proto, 1);
 		if (ret < 0)
 			goto error_close_socket;
 	}

-- 
To view, visit https://gerrit.osmocom.org/2380
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic04cb8bb5ff41f177f7f5b7f7e2a2ecc686dd4c0
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list