[PATCH] libosmo-sccp[master]: osmo_ss7: fix missing assignment of asp->xua_server

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Apr 15 20:54:51 UTC 2017


Review at  https://gerrit.osmocom.org/2363

osmo_ss7: fix missing assignment of asp->xua_server

The ASP is supposed to know via which xua_server it was established

Also, as removal from the sibling-list is conditional to asp->xua_server
being set, we have linked list corruption without this patch.

Change-Id: Ic55cfbf2166381a4bf02596ad7bbe66a37e1a76f
---
M src/osmo_ss7.c
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/63/2363/1

diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c
index 0db39ed..2d34b53 100644
--- a/src/osmo_ss7.c
+++ b/src/osmo_ss7.c
@@ -1486,6 +1486,7 @@
 	/* update the ASP reference back to the server over which the
 	 * connection came in */
 	asp->server = srv;
+	asp->xua_server = oxs;
 	llist_add_tail(&asp->siblings, &oxs->asp_list);
 	/* update the ASP socket name */
 	if (asp->sock_name)

-- 
To view, visit https://gerrit.osmocom.org/2363
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic55cfbf2166381a4bf02596ad7bbe66a37e1a76f
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list