[MERGED] osmo-bts[master]: octphy: display hint in case of wrongly configured transceiv...

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: octphy: display hint in case of wrongly configured transceiver number
......................................................................


octphy: display hint in case of wrongly configured transceiver number

Making use of the multi-trx feature requires to tell osmo-bts that
more than one transceiver are available. Otherwise it will complain
that not enough transceivers are available. This can be quite
confusing, even a correct config file will fail to parse if it
specifies more transcrivers than available.

This patch adds a hint to the error message so that the user knows
that he should check the -t commandline option

Change-Id: Ifbeacd9d43f7c6cd74a1e1b33288e66828fe843f
---
M src/common/vty.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/vty.c b/src/common/vty.c
index a48f809..44c742c 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -224,6 +224,8 @@
 	if (!trx) {
 		vty_out(vty, "Unknown TRX %u. Available TRX are: 0..%u%s",
 			trx_nr, bts->num_trx - 1, VTY_NEWLINE);
+		vty_out(vty, "Hint: Check if commandline option -t matches the"
+			"number of available transceivers!%s", VTY_NEWLINE);
 		return CMD_WARNING;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/2316
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifbeacd9d43f7c6cd74a1e1b33288e66828fe843f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder