[PATCH] osmo-bts[master]: octphy: WIP: Bug in while auto-activating all SAPIs for the ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Apr 12 17:08:38 UTC 2017


Review at  https://gerrit.osmocom.org/2314

octphy: WIP: Bug in while auto-activating all SAPIs for the BCCH/CCCH on TS0

This change most likely introduces a bug. The if that detects for TS0
in order to activate the SAPIs for the BCCH/CCCH is changed to match
on TS7. (mo->obj_inst.ts_nr == 7). So the activation definetly won't
take place when mo is related to TS0.

Probably this might be a hack, the SAPIs shall be activated later,
so on TS7 (initalization is almost through then) the SAPIS get
activated.

I need more information on this.

Change-Id: Ie307bf9f370a346686e3bd8c8a8483953a1bc279
---
M src/osmo-bts-octphy/l1_oml.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/14/2314/1

diff --git a/src/osmo-bts-octphy/l1_oml.c b/src/osmo-bts-octphy/l1_oml.c
index abbb36c..7e1ad88 100644
--- a/src/osmo-bts-octphy/l1_oml.c
+++ b/src/osmo-bts-octphy/l1_oml.c
@@ -187,7 +187,7 @@
 
 	/* hack to auto-activate all SAPIs for the BCCH/CCCH on TS0 */
 	if (mo->obj_class == NM_OC_CHANNEL && mo->obj_inst.trx_nr == 0 &&
-	    mo->obj_inst.ts_nr == 0) {
+	    mo->obj_inst.ts_nr == 7) {
 		struct gsm_lchan *cbch = gsm_bts_get_cbch(mo->bts);
 		mo->bts->c0->ts[0].lchan[CCCH_LCHAN].rel_act_kind =
 			LCHAN_REL_ACT_OML;

-- 
To view, visit https://gerrit.osmocom.org/2314
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie307bf9f370a346686e3bd8c8a8483953a1bc279
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>



More information about the gerrit-log mailing list