libosmo-sccp[master]: Add osmo-stp executable as new "Osmocom Signaling Transfer P...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Wed Apr 12 03:42:10 UTC 2017


Patch Set 2: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/#/c/2281/2//COMMIT_MSG
Commit Message:

Line 21: * SCCP: no Global Title Translatio (GTT) yet
If you rebase, add the 'n' to Translation


https://gerrit.osmocom.org/#/c/2281/2/stp/osmo_ss7_vty.c
File stp/osmo_ss7_vty.c:

Line 226: 		vty_out(vty, "cannot create route%s", VTY_NEWLINE);
Maybe print the dpc and mask here? IIRC the VTY code will not print the failing rule itself?


https://gerrit.osmocom.org/#/c/2281/2/stp/stp_main.c
File stp/stp_main.c:

Line 53: /* Hack to enable debug logging for all relevant (used?) subsystems */
hehe, it is not that bad ;)


-- 
To view, visit https://gerrit.osmocom.org/2281
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If32227b8d3127c6178e4ee45527ce65f69bc7b1e
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list