[MERGED] libosmo-sccp[master]: M3UA: Reject Message Class XFER / Type != DATA

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Apr 10 11:26:55 UTC 2017


Harald Welte has submitted this change and it was merged.

Change subject: M3UA: Reject Message Class XFER / Type != DATA
......................................................................


M3UA: Reject Message Class XFER / Type != DATA

This was discovered (and fix validated) using m3ua-sgp-mtr-i-003 of
Michael Tuexen's m3ua-testtol.

Change-Id: I7498f606b031f5a6dfb538d9900c744da6aed36f
---
M src/m3ua.c
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/m3ua.c b/src/m3ua.c
index c29ed00..9a56ff9 100644
--- a/src/m3ua.c
+++ b/src/m3ua.c
@@ -499,6 +499,9 @@
 	struct xua_msg *err = NULL;
 	struct osmo_ss7_as *as;
 
+	if (xua->hdr.msg_type != M3UA_XFER_DATA)
+		return M3UA_ERR_UNSUPP_MSG_TYPE;
+
 	/* Use routing context IE to look up the AS for which the
 	 * message was received. */
 	as = osmo_ss7_as_find_by_rctx(asp->inst, rctx);

-- 
To view, visit https://gerrit.osmocom.org/2276
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7498f606b031f5a6dfb538d9900c744da6aed36f
Gerrit-PatchSet: 6
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list