[PATCH] libosmo-sccp[master]: sccp_sap: Use zero-terminated string for GT digits in osmo_s...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Apr 9 19:31:09 UTC 2017


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2198

to look at the new patch set (#3).

sccp_sap: Use zero-terminated string for GT digits in osmo_sccp_addr

This is more natural to most application code, so simply go for ASCII
string with NUL-termination rather than an array with explicit length.

Change-Id: I6312208cdfa83184be41157a473c96e9120c63db
---
M include/osmocom/sigtran/sccp_sap.h
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/98/2198/3

diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h
index 0aa565a..e58e670 100644
--- a/include/osmocom/sigtran/sccp_sap.h
+++ b/include/osmocom/sigtran/sccp_sap.h
@@ -127,11 +127,10 @@
 
 struct osmo_sccp_gt {
 	uint8_t gti;
-	uint8_t nr_digits;
 	uint8_t tt;
 	uint32_t npi;
 	uint32_t nai;
-	uint8_t digits[32];
+	char digits[32];
 };
 
 struct osmo_sccp_addr {

-- 
To view, visit https://gerrit.osmocom.org/2198
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6312208cdfa83184be41157a473c96e9120c63db
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list