[PATCH] libosmo-sccp[master]: M3UA: Send opportunistic ASPACT-ACK to ASPACT-REQ in ACTIVE ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sun Apr 9 16:57:04 UTC 2017


Review at  https://gerrit.osmocom.org/2272

M3UA: Send opportunistic ASPACT-ACK to ASPACT-REQ in ACTIVE state

This was discovered (and fix validated) using m3ua-sgp-asptm-o-001 of
Michael Tuexen's m3ua-testtool.

Change-Id: I6d254f7a33856e036329aa717a9c03efb1f1289d
---
M src/xua_asp_fsm.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/72/2272/1

diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c
index 0996db0..2e80506 100644
--- a/src/xua_asp_fsm.c
+++ b/src/xua_asp_fsm.c
@@ -532,6 +532,12 @@
 				     PRIM_OP_INDICATION);
 		peer_send_error(fi, M3UA_ERR_UNEXPECTED_MSG);
 		break;
+	case XUA_ASP_E_ASPTM_ASPAC:
+		/* only in role SG */
+		ENSURE_SG_OR_IPSP(fi, event);
+		/* send ACK */
+		peer_send(fi, XUA_ASP_E_ASPTM_ASPAC_ACK, NULL);
+		break;
 	}
 }
 
@@ -601,6 +607,7 @@
 				 S(XUA_ASP_E_ASPSM_ASPUP) |
 				 S(XUA_ASP_E_ASPTM_ASPIA) |
 				 S(XUA_ASP_E_ASPTM_ASPIA_ACK) |
+				 S(XUA_ASP_E_ASPTM_ASPAC) |
 				 S(XUA_ASP_E_M_ASP_DOWN_REQ) |
 				 S(XUA_ASP_E_M_ASP_INACTIVE_REQ),
 		.out_state_mask = S(XUA_ASP_S_INACTIVE) |

-- 
To view, visit https://gerrit.osmocom.org/2272
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6d254f7a33856e036329aa717a9c03efb1f1289d
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list