[PATCH] openbsc[master]: abis: log known ACKs and unknown messages

[Max]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/2227

to look at the new patch set (#2).

abis: log known ACKs and unknown messages

Log expected ACK messages and unhandled messages to aid in
troubleshooting.

Change-Id: Id3afaaa76e24f63076ae0e6fd2322e4a7fa29b45
Related: OS#1614
---
M openbsc/src/libbsc/abis_nm.c
1 file changed, 22 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/27/2227/2

diff --git a/openbsc/src/libbsc/abis_nm.c b/openbsc/src/libbsc/abis_nm.c
index 33a23a2..ff0a70b 100644
--- a/openbsc/src/libbsc/abis_nm.c
+++ b/openbsc/src/libbsc/abis_nm.c
@@ -694,8 +694,25 @@
 	case NM_MT_BS11_LMT_SESSION:
 		ret = abis_nm_rx_lmt_event(mb);
 		break;
+	case NM_MT_OPSTART_ACK:
+		abis_nm_debugp_foh(DNM, foh);
+		DEBUGP(DNM, "Opstart acked by BTS %u type %s\n", bts->nr,
+		       btstype2str(bts->type));
+		break;
+	case NM_MT_SET_CHAN_ATTR_ACK:
+		abis_nm_debugp_foh(DNM, foh);
+		DEBUGP(DNM, "Set Channel Attributes acked by BTS %u type %s\n",
+		       bts->nr, btstype2str(bts->type));
+		break;
+	case NM_MT_SET_RADIO_ATTR_ACK:
+		abis_nm_debugp_foh(DNM, foh);
+		DEBUGP(DNM, "Set Radio Carrier Attributes acked by BTS %u type %s\n",
+		       bts->nr, btstype2str(bts->type));
+		break;
 	case NM_MT_CONN_MDROP_LINK_ACK:
-		DEBUGP(DNM, "CONN MDROP LINK ACK\n");
+		abis_nm_debugp_foh(DNM, foh);
+		DEBUGP(DNM, "CONN MDROP LINK acked by BTS %u type %s\n",
+		       bts->nr, btstype2str(bts->type));
 		break;
 	case NM_MT_IPACC_RESTART_ACK:
 		osmo_signal_dispatch(SS_NM, S_NM_IPACC_RESTART_ACK, NULL);
@@ -705,6 +722,10 @@
 		break;
 	case NM_MT_SET_BTS_ATTR_ACK:
 		break;
+	default:
+		LOGP(DNM, LOGL_ERROR, "Unhandled message %s from BTS type %s\n",
+		     get_value_string(abis_nm_msgtype_names, mt),
+		     btstype2str(bts->type));
 	}
 
 	abis_nm_queue_send_next(bts);

-- 
To view, visit https://gerrit.osmocom.org/2227
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id3afaaa76e24f63076ae0e6fd2322e4a7fa29b45
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder