[PATCH] openbsc[master]: abis: log known ACKs and unknown messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Apr 4 17:23:12 UTC 2017


Review at  https://gerrit.osmocom.org/2227

abis: log known ACKs and unknown messages

Log expected ACK messages and unhandled messages to aid in
troubleshooting.

Change-Id: Id3afaaa76e24f63076ae0e6fd2322e4a7fa29b45
Related: OS#1614
---
M openbsc/src/libbsc/abis_nm.c
1 file changed, 13 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/27/2227/1

diff --git a/openbsc/src/libbsc/abis_nm.c b/openbsc/src/libbsc/abis_nm.c
index 33a23a2..c8a53bf 100644
--- a/openbsc/src/libbsc/abis_nm.c
+++ b/openbsc/src/libbsc/abis_nm.c
@@ -694,6 +694,15 @@
 	case NM_MT_BS11_LMT_SESSION:
 		ret = abis_nm_rx_lmt_event(mb);
 		break;
+	case NM_MT_OPSTART_ACK:
+		DEBUGP(DNM, "Opstart acked\n");
+		break;
+	case NM_MT_SET_CHAN_ATTR_ACK:
+		DEBUGP(DNM, "Set Channel Attributes acked\n");
+		break;
+	case NM_MT_SET_RADIO_ATTR_ACK:
+		DEBUGP(DNM, "Set Radio Carrier Attributes acked\n");
+		break;
 	case NM_MT_CONN_MDROP_LINK_ACK:
 		DEBUGP(DNM, "CONN MDROP LINK ACK\n");
 		break;
@@ -705,6 +714,10 @@
 		break;
 	case NM_MT_SET_BTS_ATTR_ACK:
 		break;
+	default:
+		LOGP(DNM, LOGL_ERROR, "Unhandled message %s from BTS type %s\n",
+		     get_value_string(abis_nm_msgtype_names, mt),
+		     btstype2str(bts->type));
 	}
 
 	abis_nm_queue_send_next(bts);

-- 
To view, visit https://gerrit.osmocom.org/2227
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3afaaa76e24f63076ae0e6fd2322e4a7fa29b45
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list