This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review+1 (2 comments) https://gerrit.osmocom.org/#/c/2178/3/src/gsm/gsm0808.c File src/gsm/gsm0808.c: Line 55: (uint8_t *) & lai_ci); we normally don't mix cosmetic and non-cosmetic changes in a single patch. This one has already three cosmetic changes. Line 208: struct msgb *gsm0808_create_assignment_completed_aoip(uint8_t rr_cause, as we're changing the signature anyway, we might as well shorten the naming. "gsm0808_create_ass_compl" or if you like to prevent the "ass" use "assgn" -- To view, visit https://gerrit.osmocom.org/2178 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f866abec1822d19871052f3c647ad782785b34 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes