[MERGED] osmo-trx[master]: Transceiver: Remove unsigned negative compares

[Tom Tsou]

Tom Tsou has submitted this change and it was merged.

Change subject: Transceiver: Remove unsigned negative compares
......................................................................


Transceiver: Remove unsigned negative compares

Change-Id: I49f30699786c52736ef334dae61f7bbd65d878d5
Fixes: Coverity CID 149353, 149356
---
M Transceiver52M/Transceiver.cpp
M Transceiver52M/osmo-trx.cpp
2 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Tom Tsou: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp
index 4616fea..66eff7f 100644
--- a/Transceiver52M/Transceiver.cpp
+++ b/Transceiver52M/Transceiver.cpp
@@ -788,9 +788,9 @@
     // set TSC
     unsigned TSC;
     sscanf(buffer, "%3s %s %d", cmdcheck, command, &TSC);
-    if ((TSC < 0) || (TSC > 7))
+    if (TSC > 7) {
       sprintf(response, "RSP SETTSC 1 %d", TSC);
-    else {
+    } else {
       LOG(NOTICE) << "Changing TSC from " << mTSC << " to " << TSC;
       mTSC = TSC;
       sprintf(response,"RSP SETTSC 0 %d", TSC);
diff --git a/Transceiver52M/osmo-trx.cpp b/Transceiver52M/osmo-trx.cpp
index 5e81586..b36c081 100644
--- a/Transceiver52M/osmo-trx.cpp
+++ b/Transceiver52M/osmo-trx.cpp
@@ -168,7 +168,7 @@
 	if (!config->chans)
 		config->chans = DEFAULT_CHANS;
 
-	if (config->mcbts && ((config->chans < 0) || (config->chans > 5))) {
+	if (config->mcbts && config->chans > 5) {
 		std::cout << "Unsupported number of channels" << std::endl;
 		return false;
 	}

-- 
To view, visit https://gerrit.osmocom.org/2188
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I49f30699786c52736ef334dae61f7bbd65d878d5
Gerrit-PatchSet: 3
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Tom Tsou <tom at tsou.cc>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>