This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 4: Code-Review-1 (9 comments) getting there... https://gerrit.osmocom.org/#/c/861/4//COMMIT_MSG Commit Message: Line 10: Which expects a current bug with EPDAN for Interpretation of the (lower case after comma, also for 'interpretation') https://gerrit.osmocom.org/#/c/861/4/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 2032: int i; drop unused 'i' Line 2035: uint32_t fn = 2654167; /* 17,25,9 */ drop unused 'fn' Line 2061: * Over the Air message captured has been A test case is not simulated, it is run and by that simulates a real situation :) "Simulate a message captured during over-the-air testing, where the following values were observed: v_a = 1176, vs = 1288, max sns = 2048, window size = 480." Line 2072: dl_tbf = create_dl_tbf(&the_bts, ms_class, egprs_ms_class, &trx_no); interesting, there was an error here passing 'the_bts' instead of '&the_bts' which I didn't spot before. Line 2074: prlcdlwindow = &dl_tbf->m_window; single space please Line 2106: &bsn_begin, &bsn_end, &dl_tbf->m_window); You're not using num_blocks. Either remove it, or, rather, assert that it has the expected value. Line 2116: */ A blank line above this comment, no blank line below. Again, use a period '.' when a sentence ends, and start a new sentence with upper case. Instead of 'both condition...' please say 'Below assertions show a bug, and shall be adjusted along with the fix in a subsequent commit.' Line 2806: test_egprs_tbf_epdan_out_of_rx_window(); the naming above used the ordering 'test_tbf_egprs_*', so stick with that -- To view, visit https://gerrit.osmocom.org/861 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If32b67f5c05707155281128b776a90a1e3d587b2 Gerrit-PatchSet: 4 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes