This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/905/5/src/osmo-bts-octphy/octphy_vty.c File src/osmo-bts-octphy/octphy_vty.c: Line 139: "octphy tx-attenuation-flag <0-1>", I think the syntax and description should be more explicit. Nobody knows what a "tx attenuation flag is". The help message is also not helpful. In reality, this configures whether the OML Attribute or the config file should be used for configuring the Tx attenuation in the hardware. So something like "octphy tx-attenuation (oml|config-file)" would probably be more easily understood, particularly with more descriptive help message. As we alreday have the "octphy tx-attenuation" below, it might even make more sense to simply change that to "octphy tx-attenuation (oml|<0-359>)" so with a single command one can either state that the OML value is to be used, or that an absolute value is specified. Much better, I think. -- To view, visit https://gerrit.osmocom.org/905 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76bb8660eb1d8baeb6b8f69da4a6ba9ab7319981 Gerrit-PatchSet: 5 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes