openbsc[master]: sndcp: Fixups for sndcp layer based on coverity-scan suggest...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Sep 30 12:55:57 UTC 2016


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/965/1/openbsc/src/gprs/gprs_sndcp.c
File openbsc/src/gprs/gprs_sndcp.c:

Line 44: #define DEBUG_IP_PACKETS 1	/* 0=Disabled, 1=Enabled */
why do we enable debugging in this patch?  Is debugging required for regular operation? This shouldn't be the case. And if it's not a fix, it shouldn't be part of the patch.


-- 
To view, visit https://gerrit.osmocom.org/965
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f9adf251f5119e67ffe76baad6f1f996ac8dbad
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list