[MERGED] openbsc[master]: log CTRL bind only once

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: log CTRL bind only once
......................................................................


log CTRL bind only once

After libosmocore 38d232ee5d2ceb045d9ad6d3a23afcb4972523f7 which outputs
'CTRL at <ip> <port>' from ctrl_interface_setup_dynip(), there's no need to log
the CTRL bind here anymore.

Change-Id: I1a874efe365a1ecf8ec37b058215b95b9a635ec2
---
M openbsc/src/gprs/sgsn_main.c
M openbsc/src/osmo-bsc/osmo_bsc_main.c
M openbsc/src/osmo-bsc_nat/bsc_nat.c
M openbsc/src/osmo-nitb/bsc_hack.c
4 files changed, 0 insertions(+), 8 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/gprs/sgsn_main.c b/openbsc/src/gprs/sgsn_main.c
index 93848f5..822c359 100644
--- a/openbsc/src/gprs/sgsn_main.c
+++ b/openbsc/src/gprs/sgsn_main.c
@@ -389,8 +389,6 @@
 
 	/* start control interface after reading config for
 	 * ctrl_vty_get_bind_addr() */
-	LOGP(DGPRS, LOGL_NOTICE, "CTRL at %s %d\n",
-	     ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_SGSN);
 	ctrl = sgsn_controlif_setup(NULL, ctrl_vty_get_bind_addr(),
 				    OSMO_CTRL_PORT_SGSN);
 	if (!ctrl) {
diff --git a/openbsc/src/osmo-bsc/osmo_bsc_main.c b/openbsc/src/osmo-bsc/osmo_bsc_main.c
index 2ee5fb4..d3128e4 100644
--- a/openbsc/src/osmo-bsc/osmo_bsc_main.c
+++ b/openbsc/src/osmo-bsc/osmo_bsc_main.c
@@ -229,8 +229,6 @@
 
 	/* start control interface after reading config for
 	 * ctrl_vty_get_bind_addr() */
-	LOGP(DNM, LOGL_NOTICE, "CTRL at %s %d\n",
-	     ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_NITB_BSC);
 	bsc_gsmnet->ctrl = bsc_controlif_setup(bsc_gsmnet,
 					       ctrl_vty_get_bind_addr(),
 					       OSMO_CTRL_PORT_NITB_BSC);
diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c
index 57cc8b3..6ae8c05 100644
--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c
+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c
@@ -1669,8 +1669,6 @@
 
 	/* start control interface after reading config for
 	 * ctrl_vty_get_bind_addr() */
-	LOGP(DNAT, LOGL_NOTICE, "CTRL at %s %d\n",
-	     ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_BSC_NAT);
 	nat->ctrl = bsc_nat_controlif_setup(nat, ctrl_vty_get_bind_addr(),
 					    OSMO_CTRL_PORT_BSC_NAT);
 	if (!nat->ctrl) {
diff --git a/openbsc/src/osmo-nitb/bsc_hack.c b/openbsc/src/osmo-nitb/bsc_hack.c
index 8e1ddae..28dbb6f 100644
--- a/openbsc/src/osmo-nitb/bsc_hack.c
+++ b/openbsc/src/osmo-nitb/bsc_hack.c
@@ -313,8 +313,6 @@
 
 	/* start control interface after reading config for
 	 * ctrl_vty_get_bind_addr() */
-	LOGP(DNM, LOGL_NOTICE, "CTRL at %s %d\n",
-	     ctrl_vty_get_bind_addr(), OSMO_CTRL_PORT_NITB_BSC);
 	bsc_gsmnet->ctrl = bsc_controlif_setup(bsc_gsmnet,
 					       ctrl_vty_get_bind_addr(),
 					       OSMO_CTRL_PORT_NITB_BSC);

-- 
To view, visit https://gerrit.osmocom.org/980
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a874efe365a1ecf8ec37b058215b95b9a635ec2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder