osmo-pcu[master]: Fix: DL slot allocation based on direction configured

[arvind.sirsikar]

Patch Set 6:

(7 comments)

https://gerrit.osmocom.org/#/c/819/5//COMMIT_MSG
Commit Message:

Line 11: combined capacity of DL and UL for TS allocation.
> this would be a good place to end the sentence to make it easier to read an
Done


Line 12: Since 2nd DL TBF has less DL slot compared to 2nd TBF,
> "with this", what "this" exactly?
Done


https://gerrit.osmocom.org/#/c/819/5/src/bts.h
File src/bts.h:

Line 49: 	MAXIMISE_DIR_NONE
> In enum values we typically use a common prefix.
Done


Line 198: 	enum maximise_direction maximise_dir;
> Yes. This file is being used only in PCU
Done


https://gerrit.osmocom.org/#/c/819/5/src/gprs_rlcmac_ts_alloc.cpp
File src/gprs_rlcmac_ts_alloc.cpp:

Line 778: 		switch (bts->maximise_dir) {
> Yes. Intention is to provide flexibility for UL direction, When multi slots
Done


https://gerrit.osmocom.org/#/c/819/5/src/pcu_vty.c
File src/pcu_vty.c:

Line 504:       "maximise-direction dl",
> Yes. I am providing the flexibility to add this support for UL as well when
Done


Line 517:       NO_STR MAXIMISE_STR)
> Done
Done


-- 
To view, visit https://gerrit.osmocom.org/819
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b4a99194ccae68bb3417bce538d16e944d5ec71
Gerrit-PatchSet: 6
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes