[PATCH] osmo-bts[master]: DTX: invalidate cached SID on speech resume

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Tue Sep 27 10:36:11 UTC 2016


Review at  https://gerrit.osmocom.org/957

DTX: invalidate cached SID on speech resume

Ideally AMR have special ONSET event for speech resume which is
propagated into RTP header Marker bit. However this packet could be lost
so we should infer this event also by the presence os speech frames and
correspondingly drop saved SID.

Change-Id: I6ab91f6ce5402b1614be2ab458da65ecd8624fdc
---
M src/osmo-bts-litecell15/tch.c
M src/osmo-bts-sysmo/tch.c
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/57/957/1

diff --git a/src/osmo-bts-litecell15/tch.c b/src/osmo-bts-litecell15/tch.c
index e06c4cf..57aafa6 100644
--- a/src/osmo-bts-litecell15/tch.c
+++ b/src/osmo-bts-litecell15/tch.c
@@ -221,6 +221,8 @@
 	case 4: case 5: case 6: case 7:
 		cmi = ft;
 		LOGP(DRTP, LOGL_DEBUG, "SPEECH frame with CMI %u\n", cmi);
+		/* We received AMR SPEECH frame - invalidate saved SID */
+		lchan->tch.last_sid.len = 0;
 		break;
 	case AMR_NO_DATA:
 		LOGP(DRTP, LOGL_DEBUG, "SPEECH frame AMR NO_DATA\n");
diff --git a/src/osmo-bts-sysmo/tch.c b/src/osmo-bts-sysmo/tch.c
index b1ab086..5de8caa 100644
--- a/src/osmo-bts-sysmo/tch.c
+++ b/src/osmo-bts-sysmo/tch.c
@@ -318,6 +318,8 @@
 	case 4: case 5: case 6: case 7:
 		cmi = ft;
 		LOGP(DRTP, LOGL_DEBUG, "SPEECH frame with CMI %u\n", cmi);
+		/* We received AMR SPEECH frame - invalidate saved SID */
+		lchan->tch.last_sid.len = 0;
 		break;
 	case AMR_NO_DATA:
 		LOGP(DRTP, LOGL_DEBUG, "SPEECH frame AMR NO_DATA\n");

-- 
To view, visit https://gerrit.osmocom.org/957
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ab91f6ce5402b1614be2ab458da65ecd8624fdc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list