This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgHarald Welte has submitted this change and it was merged. Change subject: log VTY telnet bind only once ...................................................................... log VTY telnet bind only once After libosmocore 55dc2edc89c1a85187ef8aafc09f7d922383231f which outputs 'telnet at <ip> <port>' from telnet_init_dynif(), there's no need to log the telnet VTY bind here anymore. Change-Id: I97a730b28759df1d549a5049f47a3da1c16a3447 --- M openbsc/src/gprs/gb_proxy_main.c M openbsc/src/gprs/gtphub_main.c M openbsc/src/gprs/sgsn_main.c M openbsc/src/libbsc/bsc_init.c M openbsc/src/osmo-bsc_mgcp/mgcp_main.c M openbsc/src/osmo-bsc_nat/bsc_nat.c 6 files changed, 0 insertions(+), 12 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/openbsc/src/gprs/gb_proxy_main.c b/openbsc/src/gprs/gb_proxy_main.c index 0c3cfbe..2ddfca7 100644 --- a/openbsc/src/gprs/gb_proxy_main.c +++ b/openbsc/src/gprs/gb_proxy_main.c @@ -271,8 +271,6 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - LOGP(DGPRS, LOGL_NOTICE, "VTY at %s %d\n", - vty_get_bind_addr(), OSMO_VTY_PORT_GBPROXY); rc = telnet_init_dynif(tall_bsc_ctx, &dummy_network, vty_get_bind_addr(), OSMO_VTY_PORT_GBPROXY); if (rc < 0) diff --git a/openbsc/src/gprs/gtphub_main.c b/openbsc/src/gprs/gtphub_main.c index 89582b1..1e20a63 100644 --- a/openbsc/src/gprs/gtphub_main.c +++ b/openbsc/src/gprs/gtphub_main.c @@ -325,8 +325,6 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - LOGP(DGTPHUB, LOGL_NOTICE, "VTY at %s %d\n", - vty_get_bind_addr(), OSMO_VTY_PORT_GTPHUB); rc = telnet_init_dynif(osmo_gtphub_ctx, 0, vty_get_bind_addr(), OSMO_VTY_PORT_GTPHUB); if (rc < 0) diff --git a/openbsc/src/gprs/sgsn_main.c b/openbsc/src/gprs/sgsn_main.c index fb5b6d5..93848f5 100644 --- a/openbsc/src/gprs/sgsn_main.c +++ b/openbsc/src/gprs/sgsn_main.c @@ -382,8 +382,6 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - LOGP(DGPRS, LOGL_NOTICE, "VTY at %s %d\n", - vty_get_bind_addr(), OSMO_VTY_PORT_SGSN); rc = telnet_init_dynif(tall_bsc_ctx, &dummy_network, vty_get_bind_addr(), OSMO_VTY_PORT_SGSN); if (rc < 0) diff --git a/openbsc/src/libbsc/bsc_init.c b/openbsc/src/libbsc/bsc_init.c index 06f4121..c38bca1 100644 --- a/openbsc/src/libbsc/bsc_init.c +++ b/openbsc/src/libbsc/bsc_init.c @@ -491,8 +491,6 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - LOGP(DNM, LOGL_NOTICE, "VTY at %s %d\n", - vty_get_bind_addr(), OSMO_VTY_PORT_NITB_BSC); rc = telnet_init_dynif(tall_bsc_ctx, bsc_gsmnet, vty_get_bind_addr(), OSMO_VTY_PORT_NITB_BSC); if (rc < 0) diff --git a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c index e226b02..ac55e25 100644 --- a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c +++ b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c @@ -233,8 +233,6 @@ return rc; /* start telnet after reading config for vty_get_bind_addr() */ - LOGP(DMGCP, LOGL_NOTICE, "VTY at %s %d\n", - vty_get_bind_addr(), OSMO_VTY_PORT_BSC_MGCP); rc = telnet_init_dynif(tall_bsc_ctx, &dummy_network, vty_get_bind_addr(), OSMO_VTY_PORT_BSC_MGCP); if (rc < 0) diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c index f20b248..57cc8b3 100644 --- a/openbsc/src/osmo-bsc_nat/bsc_nat.c +++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c @@ -1639,8 +1639,6 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - LOGP(DNAT, LOGL_NOTICE, "VTY at %s %d\n", - vty_get_bind_addr(), OSMO_VTY_PORT_BSC_NAT); if (telnet_init_dynif(tall_bsc_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_BSC_NAT)) { fprintf(stderr, "Creating VTY telnet line failed\n"); -- To view, visit https://gerrit.osmocom.org/952 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97a730b28759df1d549a5049f47a3da1c16a3447 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder