[MERGED] osmo-iuh[master]: log VTY telnet bind only once

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Tue Sep 27 04:59:49 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: log VTY telnet bind only once
......................................................................


log VTY telnet bind only once

After libosmocore 55dc2edc89c1a85187ef8aafc09f7d922383231f which outputs
'telnet at <ip> <port>' from telnet_init_dynif(), there's no need to log the
telnet VTY bind here anymore.

Change-Id: Icd9e670c1d30c156f7bd5d0d34892150aeba95e9
---
M src/hnbgw.c
M src/tests/hnb-test.c
2 files changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/hnbgw.c b/src/hnbgw.c
index d50e622..8c860b1 100644
--- a/src/hnbgw.c
+++ b/src/hnbgw.c
@@ -474,8 +474,6 @@
 		log_set_log_level(osmo_stderr_target,
 				  hnbgw_cmdline_config.log_level);
 
-	LOGP(DMAIN, LOGL_NOTICE, "VTY at %s %d\n",
-	     vty_get_bind_addr(), 2323);
 	rc = telnet_init_dynif(NULL, g_hnb_gw, vty_get_bind_addr(), 2323);
 	if (rc < 0) {
 		perror("Error binding VTY port");
diff --git a/src/tests/hnb-test.c b/src/tests/hnb-test.c
index d338077..68a3117 100644
--- a/src/tests/hnb-test.c
+++ b/src/tests/hnb-test.c
@@ -944,7 +944,6 @@
 	vty_init(&vty_info);
 	hnbtest_vty_init();
 
-	printf("VTY at %s %d\n", vty_get_bind_addr(), 2324);
 	rc = telnet_init_dynif(NULL, NULL, vty_get_bind_addr(), 2324);
 	if (rc < 0) {
 		perror("Error binding VTY port");

-- 
To view, visit https://gerrit.osmocom.org/951
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd9e670c1d30c156f7bd5d0d34892150aeba95e9
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list